Added Engine Configuration with Object Storage through Terraform #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shobhit181
requested review from
Uddipaan-Hazarika,
elima-sugunan and
gmanhas23
Shobhit181
force-pushed
the
engine-conf-changes-ntp-object
branch
12 times, most recently
from
a2a1fe4 to
0bfe909
Compare
| _, ntpError := setNtpServers(ctx, client, engine_host, ntp_servers, ntp_timezone) | ||
| if ntpError != nil { | ||
| return diag.Errorf("Error setting NTP servers: %s", ntpError) | ||
| } |
Contributor
There was a problem hiding this comment.
remove commented lines. and also are these setNtpServers call synchronous by design?
Uddipaan-Hazarika
approved these changes
Dec 16, 2025
Contributor
Uddipaan-Hazarika
left a comment
Uddipaan-Hazarika
left a comment
There was a problem hiding this comment.
Approving it to unblock you. but do checkout the comments.
gmanhas23
approved these changes
Dec 16, 2025
Shobhit181
force-pushed
the
engine-conf-changes-ntp-object
branch
3 times, most recently
from
b0d655c to
075d821
Compare
Shobhit181
force-pushed
the
engine-conf-changes-ntp-object
branch
from
075d821 to
b0764b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Delphix terraform provider does not have a capability to configure Delphix Engine
Solution:
Added support for -
delphix_engine_configurationdelphix_engine_registrationObject Storage (AWS S3)andBlock storageROLEandACCESS_KEYNTP,SMTPandDNSconfigurationWeb proxyconfigurationphone homeanduser analyticsconfigurationsSSO based AuthenticationconfigurationsTesting
ACCEPTANCE Test for Engine Registration -
ACCEPTANCE Test for Engine Configuration -
2. Object Storage
3. Comprehensive Test - This test includes
* sysadmin password change
* NTP config
* DNS config
* SMTP config
* User analytics and Phone home
* Web Proxy config
* Object storage config
* user password change